Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if scene change frame count does not match #618

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Error if scene change frame count does not match #618

merged 1 commit into from
Apr 20, 2022

Conversation

shssoichiro
Copy link
Collaborator

@shssoichiro shssoichiro commented Apr 18, 2022 •
edited

This way potential issues with input sources or filters can be caught sooner.

@shssoichiro
Copy link
Collaborator Author 

error: the function has a cognitive complexity of (26/25)
  --> av1an-core/src/scene_detect.rs:71:8
   |
71 | pub fn scene_detect(
   |        ^^^^^^^^^^^^
   |

despair

@shssoichiro shssoichiro requested a review from redzic April 20, 2022 00:45
@redzic
Copy link
Collaborator

redzic commented Apr 20, 2022

I think we should probably error here, I'm not sure if it would ever make sense for the user to ignore this scenario

@shssoichiro shssoichiro changed the title Warn if scene change frame count does not match Error if scene change frame count does not match Apr 20, 2022
@mergify mergify bot merged commit fc4bf94 into master-of-zen:master Apr 20, 2022
@shssoichiro shssoichiro deleted the warn-sc-incomplete branch April 20, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redzic redzic redzic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shssoichiro @redzic