Improve selection of HDR content #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redzic
reviewed
May 16, 2022
av1an-core/src/lib.rs
Outdated
| return Ok(TransferFunction::SMPTE2084); | ||
| } | ||
| if enc_params.iter().any(|p| { | ||
| let p = p.to_lowercase(); |
There was a problem hiding this comment.
My only (extremely minor) nitpick is that these 2 to_lowercase function calls could instead be to_ascii_lowercase, which are theoretically a lot faster because they don't have to load values from a huge utf8 lookup table.
There was a problem hiding this comment.
Technically true. It won't affect overall performance as this function is called at most twice per encode, but since it's still in PR might as well make it the better version.
Currently this only applies to grain synth generation, but the prior implementation of HDR detection only looked at the props on the input video. Those may not necessarily be set correctly even if the user is encoding to HDR, so we want to prioritize looking at the encoder params, then fallback to checking the input if the user has not set a transfer characteristic on the encoder.
shssoichiro
force-pushed
the
improve-hdr-input-detection
branch
from
e564fa9
to
00cbb21
Compare
redzic
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this only applies to grain synth generation,
but the prior implementation of HDR detection only looked at the props
on the input video. Those may not necessarily be set correctly even if
the user is encoding to HDR, so we want to prioritize looking at the
encoder params, then fallback to checking the input if the user has not
set a transfer characteristic on the encoder.