Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vmaf_percentile to 1, default vmaf rate to 1 #641

Merged
merged 2 commits into from
Jun 25, 2022
Merged

Conversation

master-of-zen
Copy link
Owner

I think target quality need a lot of work and improvement.

  • vmaf_percentile to 1,
  • default vmaf rate to 1

@BlueSwordM
Copy link
Contributor

Denied. We should put it to vmaf_percentile to 5% (0.05) and the default vmaf subsampling rate to 1/2.

In fact, we should introduced VMAF percentile controls like I tried to do here, but then stopped:
https://github.com/BlueSwordM/Av1an/tree/av1an_tq_percentile

@master-of-zen
Copy link
Owner Author

master-of-zen commented Jun 25, 2022

I'm certain that those are needed changes
First is that GOP structure, and pyramid changes if you have VMAF rate >1, which impacts probes accuracy, in quite unpredictable way, even more on anything that have motion.
Second is that I have seen in many instances where results were quite suboptimal because of high percentile, the idea behind having it at 25 initially was to capture those frames that are worse and have disproportional impact to perceived quality.
On my revisiting of that decision, and looking into specific instances where catching bad frames, 25 percentiles were not enough. It's simply not as aggressive as it should be, I have been noticing quality difference with less than 5 frames that had bad results, and they were not reflected by 25 percentile.

Copy link
Collaborator

@redzic redzic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to updating adapt_probing_rate, the actual default value needed to be updated as well. Other than that, I think these changes make sense as a default, and it also makes it more consistent with the default scene detection settings, in that they are the highest accuracy/quality by default. Other issues with target quality can be addressed in future PRs.

@mergify mergify bot merged commit 7af5761 into master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants