Migrate grain synth code to external crate and allow chroma grain synth #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation is simplistic in that it only enables chroma scaling from luma noise based on the `--photon-noise` strength. However, it's 100% more chroma noise capability than av1an had previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates grain parsing and generation code to external crate (which is shared with rav1e).
Also adds
--chroma-noiseoption to enable chroma grain synth.This implementation is simplistic in that it only enables chroma scaling
from luma noise based on the
--photon-noisestrength. However, it's100% more chroma noise capability than av1an had previously.