Temporarily disable steady ticks on progress bars #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where the fps and eta would not update until the very end of the encode. See also console-rs/indicatif#493
shssoichiro
force-pushed
the
fix-progress
branch
from
a47ddee
to
dc2dbb7
Compare
|
It seems like there may be further weirdness going on. The estimated fps and eta are now varying wildly from one second to the next. |
|
It looks like this bug and the issue with the fps and eta values wildly fluctuating are two separate, unrelated issues, so I'm going to push this forward as its own fix. |
master-of-zen
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the fps and eta would not update until the very end of the encode.
See also console-rs/indicatif#493