Action: Test target-quality is working correctly. #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a good test 👍🏽 |
|
UNFORTUNATELY, we can't merge it because it doesn't pass tests 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #719
Adds a test to make sure target-quality is actually working by encoding at a target of 95 and 80 and then comparing to make sure the 95 version is bigger than the 80. In the event that it does fail it will also cat the log files to make sure so the developers can see what is happening and adjust the test or fix the issue if there is one.
In this case we can see that there is no vmaf comparison happening and av1an is just doing a normal chunk encoding thus the two 95 and 80 are exactly the same size and is validated by the logs.