Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append to log file #817

Merged
merged 2 commits into from
Mar 28, 2024
Merged

append to log file #817

merged 2 commits into from
Mar 28, 2024

Conversation

jcj83429
Copy link
Contributor

When resuming, append to the log file instead of clearing its old contents.

I tested with and without resume.

@jcj83429
append to log file
d423408 
When resuming, append to the log file instead of clearing its old contents
shssoichiro
shssoichiro approved these changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@shssoichiro shssoichiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. The CI failure seems unrelated, probably some new clippy lint. I'll get that fixed but you'll need to rebase after.

@shssoichiro
Copy link
Collaborator

Blocked by #819

@shssoichiro shssoichiro merged commit 6632b47 into master-of-zen:master Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssoichiro shssoichiro shssoichiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcj83429 @shssoichiro @master-of-zen