-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolute instead of canonicalize for better Windows path handling #861
base: master
Are you sure you want to change the base?
Conversation
Anyway, here are my proposed change for this PR diff --git a/av1an-core/src/vapoursynth.rs b/av1an-core/src/vapoursynth.rs
index 7c8484e..4a5f1f5 100644
--- a/av1an-core/src/vapoursynth.rs
+++ b/av1an-core/src/vapoursynth.rs
@@ -5,7 +5,6 @@ use std::path::{Path, PathBuf};
use anyhow::{anyhow, bail};
use once_cell::sync::Lazy;
-use path_abs::PathAbs;
use std::process::Command;
use vapoursynth::prelude::*;
use vapoursynth::video_info::VideoInfo;
@@ -201,13 +200,13 @@ pub fn create_vs_file(
let mut load_script = File::create(&load_script_path)?;
- let cache_file = PathAbs::new(temp.join("split").join(format!(
+ let cache_file = to_absolute_path(&temp.join("split").join(format!(
"cache.{}",
match chunk_method {
ChunkMethod::FFMS2 => "ffindex",
ChunkMethod::LSMASH => "lwi",
ChunkMethod::DGDECNV => "dgi",
- ChunkMethod::BESTSOURCE => "json",
+ ChunkMethod::BESTSOURCE => "bsindex",
_ => return Err(anyhow!("invalid chunk method")),
}
)))?; |
I can confirm that this PR fixes bestsource performance, my proposed changes is not necessary, but it's up to you if you want |
Seems like a good idea to include anyway. Unfortunately what is blocking this PR is that something seems broken with the |
Closes #860