Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLVs #3

Open
emersion opened this issue Oct 9, 2020 · 3 comments
Open

Add support for TLVs #3

emersion opened this issue Oct 9, 2020 · 3 comments

Comments

@emersion
Copy link

emersion commented Oct 9, 2020

The PP2_TYPE_ALPN TLV is necessary to negotiate HTTP/2.

@mastercactapus
Copy link
Owner

I started this in the tlv branch, and want to test it with some in-the-wild software before merging & releasing.

@vmihailenco
Copy link

@mastercactapus I am about to try this so I wonder what were your conclusions after testing TLV support?

@Embraser01
Copy link

I started this in the tlv branch, and want to test it with some in-the-wild software before merging & releasing.

Hi @mastercactapus, after having issue with AWS Network Load Balancer (that add TLV), I tested your tlv branch with caddy v2.7.4 and I'm happy to say that it worked perfectly 💯

Would it be possible to release a new version with the TLV feature?

PS : For those who want to test it with Caddy, you can do it like this:

xcaddy build \
  --with github.com/mastercactapus/proxyprotocol=github.com/mastercactapus/proxyprotocol@tlv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants