Remove the ability to change a sell order without cancelling it first #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 20, 2014
|
+1 |
|
+1 on this one. Seems simpler than #40 to me. Don't feel strongly about it though. |
|
+1 for #39 - simplicity = good :) Rather avoid an additional message if possible, good to keep all selloffer logic together IMO. Sells must be confirmed cancelled before a new one can be created; love it +100 - will cut down code complexity |
|
+1. Simpler the better |
|
See the ongoing discussion in #40 |
|
Both this one and #40 are identical from the user's perspective. I plan to merge this one soon if there are no objections. |
|
There may be a new pull request with a replace/cancel command. See #40 for discussion. |
|
Guys, I need you to weigh in on #41, which seems like the best solution from a user-experience perspective. |
|
Going for #41, closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request could replace #38.
The general idea is to remove the ability to change a sell order without cancelling the existing one first. This should remove the race condition where you end up broadcasting a new order instead of changing the old one.