Skip to content

Commit

Permalink
Add comment that we don't need to link against clang_rt with ROCm 5.5
Browse files Browse the repository at this point in the history
  • Loading branch information
Rombur committed Jul 27, 2023
1 parent 6cffdb4 commit 74b5043
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cmake/Modules/FindTPLROCM.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ include(FindPackageHandleStandardArgs)
FIND_LIBRARY(AMD_HIP_LIBRARY amdhip64 PATHS ENV ROCM_PATH PATH_SUFFIXES lib)
FIND_LIBRARY(HSA_RUNTIME_LIBRARY hsa-runtime64 PATHS ENV ROCM_PATH PATH_SUFFIXES lib)

# FIXME_HIP Starting with ROCm 5.5 it is not necessary to link againt clang_rt.
# We keep the code as is for now because it is hard to find the version of ROCM
# found.
# clang_rt.builtins is necessary to use half precision. The following code to
# find clang_rt.buitins is based on
# https://github.com/ROCm-Developer-Tools/HIP/blob/develop/hip-lang-config.cmake.in#L99-L111
Expand Down

0 comments on commit 74b5043

Please sign in to comment.