Fix compiling code using Kokkos::printf for OpenMPTarget on Intel GPUs (

kokkos#6443) * Fix compiling code using Kokkos::printf for OpenMPTarget on Intel GPUs * Also guard test case
masterleinad · Sep 19, 2023 · 8239de5 · 8239de5
1 parent 36af9d6
commit 8239de5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/core/src/impl/Kokkos_Printf.hpp b/core/src/impl/Kokkos_Printf.hpp
@@ -39,11 +39,14 @@ KOKKOS_FUNCTION void printf(const char* format, Args... args) {
   else
     sycl::ext::oneapi::experimental::printf(format, args...);
 #else
-  if constexpr (sizeof...(Args) == 0)
-    ::printf("%s", format);
+  if constexpr (sizeof...(Args) == 0) ::printf("%s", format);
+    // FIXME_OPENMPTARGET non-string-literal argument used in printf is not
+    // supported for spir64
+#if !(defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU))
   else
     ::printf(format, args...);
 #endif
+#endif
 }
 
 }  // namespace Kokkos

diff --git a/core/unit_test/TestPrintf.hpp b/core/unit_test/TestPrintf.hpp
@@ -30,4 +30,8 @@ void test_kokkos_printf() {
   ASSERT_EQ(captured, expected_string);
 }
 
+// FIXME_OPENMPTARGET non-string-literal argument used in printf is not
+// supported for spir64
+#if !(defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU))
 TEST(TEST_CATEGORY, kokkos_printf) { test_kokkos_printf<TEST_EXECSPACE>(); }
+#endif