Skip to content

Commit

Permalink
Remove workaround for submit_barrier not being enqueued properly
Browse files Browse the repository at this point in the history
  • Loading branch information
masterleinad committed Mar 16, 2023
1 parent 9480cb5 commit be14872
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions core/src/SYCL/Kokkos_SYCL_Space.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,8 @@ void DeepCopySYCL(void* dst, const void* src, size_t n) {

void DeepCopyAsyncSYCL(const Kokkos::Experimental::SYCL& instance, void* dst,
const void* src, size_t n) {
// FIXME_SYCL memcpy doesn't respect submit_barrier which means that we need
// to actually fence the execution space to make sure the memcpy is properly
// enqueued when using out-of-order queues.
sycl::queue& q = *instance.impl_internal_space_instance()->m_queue;
q.wait_and_throw();
auto event = q.memcpy(dst, src, n);
auto event = q.memcpy(dst, src, n);
q.ext_oneapi_submit_barrier(std::vector<sycl::event>{event});
}

Expand Down

0 comments on commit be14872

Please sign in to comment.