Skip to content

Commit

Permalink
Improve FIXMEs
Browse files Browse the repository at this point in the history
  • Loading branch information
@masterleinad
masterleinad committed Jan 30, 2024
1 parent 16ec5cc commit cc1b254
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 28 deletions.
12 changes: 6 additions & 6 deletions core/unit_test/TestMathematicalSpecialFunctions.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1970,7 +1970,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesselj0y0) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselJ0Y0Function<TEST_EXECSPACE> test;
test.testit();
Expand All @@ -1980,7 +1980,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesselj1y1) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselJ1Y1Function<TEST_EXECSPACE> test;
test.testit();
Expand All @@ -1990,7 +1990,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesseli0k0) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselI0K0Function<TEST_EXECSPACE> test;
test.testit();
Expand All @@ -2000,7 +2000,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesseli1k1) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselI1K1Function<TEST_EXECSPACE> test;
test.testit();
Expand All @@ -2010,7 +2010,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesselh1stkind) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselH1Function<TEST_EXECSPACE> test;
test.testit();
Expand All @@ -2020,7 +2020,7 @@ TEST(TEST_CATEGORY, mathspecialfunc_cbesselh2ndkind) {
#if defined(KOKKOS_ENABLE_OPENMPTARGET) && defined(KOKKOS_ARCH_INTEL_GPU)
if (std::is_same_v<TEST_EXECSPACE, Kokkos::Experimental::OpenMPTarget>)
GTEST_SKIP() << "skipping since test is known to fail with OpenMPTarget on "
"Intel GPUs";
"Intel GPUs"; // FIXME_OPENMPTARGET
#endif
TestComplexBesselH2Function<TEST_EXECSPACE> test;
test.testit();
Expand Down
44 changes: 22 additions & 22 deletions core/unit_test/TestNumericTraits.hpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,8 @@ TEST(TEST_CATEGORY, numeric_traits_infinity) {
#endif
TestNumericTraits<TEST_EXECSPACE, float, Infinity>();
TestNumericTraits<TEST_EXECSPACE, double, Infinity>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, Infinity>();
Expand All @@ -225,7 +225,7 @@ TEST(TEST_CATEGORY, numeric_traits_epsilon) {
#endif
TestNumericTraits<TEST_EXECSPACE, float, Epsilon>();
TestNumericTraits<TEST_EXECSPACE, double, Epsilon>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_NVHPC 23.7 long double
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, Epsilon>();
Expand All @@ -240,7 +240,7 @@ TEST(TEST_CATEGORY, numeric_traits_round_error) {
#endif
TestNumericTraits<TEST_EXECSPACE, float, RoundError>();
TestNumericTraits<TEST_EXECSPACE, double, RoundError>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_NVHPC 23.7 long double
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, RoundError>();
Expand All @@ -254,7 +254,7 @@ TEST(TEST_CATEGORY, numeric_traits_norm_min) {
#endif
TestNumericTraits<TEST_EXECSPACE, float, NormMin>();
TestNumericTraits<TEST_EXECSPACE, double, NormMin>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_NVHPC 23.7 long double
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, NormMin>();
Expand All @@ -264,7 +264,7 @@ TEST(TEST_CATEGORY, numeric_traits_norm_min) {
TEST(TEST_CATEGORY, numeric_traits_denorm_min) {
TestNumericTraits<TEST_EXECSPACE, float, DenormMin>();
TestNumericTraits<TEST_EXECSPACE, double, DenormMin>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_NVHPC 23.7 long double
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, DenormMin>();
Expand Down Expand Up @@ -303,8 +303,8 @@ TEST(TEST_CATEGORY, numeric_traits_finite_min_max) {
TestNumericTraits<TEST_EXECSPACE, float, FiniteMax>();
TestNumericTraits<TEST_EXECSPACE, double, FiniteMin>();
TestNumericTraits<TEST_EXECSPACE, double, FiniteMax>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, FiniteMin>();
Expand All @@ -329,8 +329,8 @@ TEST(TEST_CATEGORY, numeric_traits_digits) {
TestNumericTraits<TEST_EXECSPACE, Kokkos::Experimental::bhalf_t, Digits>();
TestNumericTraits<TEST_EXECSPACE, float, Digits>();
TestNumericTraits<TEST_EXECSPACE, double, Digits>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, Digits>();
Expand All @@ -354,8 +354,8 @@ TEST(TEST_CATEGORY, numeric_traits_digits10) {
TestNumericTraits<TEST_EXECSPACE, Kokkos::Experimental::bhalf_t, Digits10>();
TestNumericTraits<TEST_EXECSPACE, float, Digits10>();
TestNumericTraits<TEST_EXECSPACE, double, Digits10>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, Digits10>();
Expand All @@ -365,8 +365,8 @@ TEST(TEST_CATEGORY, numeric_traits_digits10) {
TEST(TEST_CATEGORY, numeric_traits_max_digits10) {
TestNumericTraits<TEST_EXECSPACE, float, MaxDigits10>();
TestNumericTraits<TEST_EXECSPACE, double, MaxDigits10>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, MaxDigits10>();
Expand All @@ -389,8 +389,8 @@ TEST(TEST_CATEGORY, numeric_traits_radix) {
TestNumericTraits<TEST_EXECSPACE, Kokkos::Experimental::bhalf_t, Radix>();
TestNumericTraits<TEST_EXECSPACE, float, Radix>();
TestNumericTraits<TEST_EXECSPACE, double, Radix>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, Radix>();
Expand All @@ -406,8 +406,8 @@ TEST(TEST_CATEGORY, numeric_traits_min_max_exponent) {
TestNumericTraits<TEST_EXECSPACE, float, MaxExponent>();
TestNumericTraits<TEST_EXECSPACE, double, MinExponent>();
TestNumericTraits<TEST_EXECSPACE, double, MaxExponent>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, MinExponent>();
Expand All @@ -420,8 +420,8 @@ TEST(TEST_CATEGORY, numeric_traits_min_max_exponent10) {
TestNumericTraits<TEST_EXECSPACE, float, MaxExponent10>();
TestNumericTraits<TEST_EXECSPACE, double, MinExponent10>();
TestNumericTraits<TEST_EXECSPACE, double, MaxExponent10>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, MinExponent10>();
Expand All @@ -441,8 +441,8 @@ TEST(TEST_CATEGORY, numeric_traits_quiet_and_signaling_nan) {
TestNumericTraits<TEST_EXECSPACE, float, SignalingNaN>();
TestNumericTraits<TEST_EXECSPACE, double, QuietNaN>();
TestNumericTraits<TEST_EXECSPACE, double, SignalingNaN>();
// FIXME_NVHPC long double not supported, 23.7 long double
// FIXME_OPENMPTARGET
// FIXME_NVHPC 23.7 long double
// FIXME_OPENMPTARGET long double on Intel GPUs
#if (!defined(KOKKOS_ENABLE_CUDA) || !defined(KOKKOS_COMPILER_NVHPC)) && \
(!defined(KOKKOS_ENABLE_OPENMPTARGET) || !defined(KOKKOS_ARCH_INTEL_GPU))
TestNumericTraits<TEST_EXECSPACE, long double, QuietNaN>();
Expand Down

0 comments on commit cc1b254

Please sign in to comment.