fix: flag for local vs remote init was wrong #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberenice
approved these changes
Jul 27, 2023
| @@ -53,12 +53,12 @@ tasks: | |||
|
|
|||
| - | | |||
| echo -e "\n" | |||
| if [[ -z "{{.TASKIT_LOCAL_PATH}}" ]]; then | |||
There was a problem hiding this comment.
Ah, I was sure I saw -n, not -z somewhere. I tested that! 😆
There was a problem hiding this comment.
It was somewhere... Not sure what happened, but I messed it up!
There was a problem hiding this comment.
I blame bash for their unreadable, horrible conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
local vs remote flag in init: This was broken and never working. Realized within client project.
Updates to use
httpsgit clone instead ofsshas SSH did not work in GHAs without creating a user and all that jazz. We may need to get more complicated here in the future, but hopefully not.Adds
SNAPSHOT_ENVvar to snaplet snapshot paths (viauploadanddownloadtasks) in S3 for differentiating dev vs stage vs prod vs whatever snapshots.We need tests for this stuff... Is there any common approach to testing Taskfile implementations? go-task/task#1283