Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renames snaplet vars to avoid collisions #5

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Conversation

Gowiem
Copy link
Member

@Gowiem Gowiem commented Sep 27, 2023

Info

  • Updates snaplet var SNAPSHOT_NAME to not be used in the snaplet:download or snaplet:restore tasks as that was causing collisions and wasn't allowing us to overwrite those vars. Updates those vars to RESTORE_SNAPSHOT which keeps it unique and helps avoid the issue.
  • Updates the toolbox tasks a tiny bit, but this is still a WIP.

@Gowiem Gowiem self-assigned this Sep 27, 2023
fix: clean needs to be passed the snapshot path
Copy link
Member

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gowiem Gowiem merged commit a4631cd into main Sep 27, 2023
1 check passed
@Gowiem Gowiem deleted the fix/var-collisions branch September 27, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants