upgrade to latest module 'cloudposse/label/null' + fixes #10

[gberenice]

Info

• This removes excessive label modules.
• Updates modules and hooks versions.
• Addresses KMS Key Policy too broad #10

[Gowiem]

Because we're keeping the same context EXCEPT the attributes, we'd break existing users usage of this module when they upgrade. Let's add that attributes, so we don't mess up folks usage of this module.

Suggested change

	context = module.this.context
	context = module.this.context
	attributes = attributes = compact(concat(["logs"], module.this.attributes))

[gberenice]

@Gowiem I decided to keep label modules for logs, role and ASG in order to avoid undesired recreation of the resources caused by renaming. We could circle back on the refactoring like this in case we work on other major updates sometime later that will require the replacement.

[Gowiem]

Should we use asg_label here?

[gberenice]

Updated 👍

[gberenice]

@Gowiem the variable max_instance_lifetime was removed as well, since we're not going to use it as we thought.

With all the above, the plan for existing infra should be like:

  # module.ssm_agent.aws_autoscaling_group.default will be updated in-place
  ~ resource "aws_autoscaling_group" "default" {
      + force_delete_warm_pool    = false
        id                        = "sts-prod-ssm-agent-asg20201203003845865900000004"
        name                      = "sts-prod-ssm-agent-asg20201203003845865900000004"
      ~ tags                      = [
          + {
              + "key"                 = "Attributes"
              + "propagate_at_launch" = "true"
              + "value"               = "asg"
            },
          - {
              - "key"                 = "Name"
              - "propagate_at_launch" = "true"
              - "value"               = "sts-prod-ssm-agent"
            },
          + {
              + "key"                 = "Name"
              + "propagate_at_launch" = "true"
              + "value"               = "sts-prod-ssm-agent-asg"
            },
          + {},
            # (2 unchanged elements hidden)
        ]
        # (23 unchanged attributes hidden)

        # (1 unchanged block hidden)
    }

[Gowiem]

@gberenice looks great, let's !

[gberenice]

@Gowiem I've updated the PR to address #10. Please review.