Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lifecycle rules + repo chores #17

Merged
merged 4 commits into from
Jun 26, 2023
Merged

fix: lifecycle rules + repo chores #17

merged 4 commits into from
Jun 26, 2023

Conversation

gberenice
Copy link
Member

what

  • Fix transition misconfiguration that happened during migration to the latest S3 bucket module: don't transfer to STANDARD_IA and DEEP_ARCHIVE.
  • Add CODEOWNERS and PR template file.

why

  • Transition values were not valid.
  • Following some best practices.

references

  • N/A

@gberenice gberenice requested a review from Gowiem June 26, 2023 11:11
# Order is important: the last matching pattern takes the most precedence

# These owners will be the default owners for everything
* @masterpointio/masterpoint-internal
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an editorconfig file?

Suggested change
* @masterpointio/masterpoint-internal
* @masterpointio/masterpoint-internal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - added the editorconfig file.

Gowiem
Gowiem previously approved these changes Jun 26, 2023
@gberenice gberenice merged commit 76992e9 into master Jun 26, 2023
@gberenice gberenice deleted the fix/lifecycle_rules branch February 5, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants