Update docs and fix example #19
Conversation
There was a problem hiding this comment.
@mheffner good stuff, thanks for circling back! This is definitely not on you for forgetting, but on us for not having legitimate CI checks in place to enforce this sort of thing. Something we have on our backlog, but haven't implemented due to client work that takes priority.
Anyway, small nitpick + one question. Thanks!
README.md
Outdated
| @@ -82,7 +82,7 @@ Use [the awesome `gossm` project](https://github.com/gjbae1212/gossm). | |||
|
|
|||
| | Name | Version | | |||
| |------|---------| | |||
| | <a name="provider_aws"></a> [aws](#provider\_aws) | >= 4.0 | | |||
| | <a name="provider_aws"></a> [aws](#provider\_aws) | 5.35.0 | | |||
There was a problem hiding this comment.
This is such an annoying issue with terraform-docs, they pin to your explicit version instead of the version constraint in versions.tf. Mind reverting this single line?
| @@ -33,3 +33,9 @@ variable "nat_gateway_enabled" { | |||
| type = bool | |||
| description = "Whether to enable NAT Gateways. If false, then the application uses NAT Instances, which are much cheaper." | |||
| } | |||
|
|
|||
| variable "ipv6_enabled" { | |||
There was a problem hiding this comment.
Is this variable used in complete/main.tf and you just forgot to include the variable?
There was a problem hiding this comment.
I'm not sure, it looks like it was introduced back in June. I added the variable definition here because it is currently failing the terraform_validate pre-commit check.
what
why
references