Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update examples/complete #8

Merged
merged 4 commits into from
Nov 20, 2023
Merged

fix: update examples/complete #8

merged 4 commits into from
Nov 20, 2023

Conversation

gberenice
Copy link
Member

@gberenice gberenice commented Nov 20, 2023 •
edited
Loading

what

  • Update examples/complete with valid configuration.
  • Update README.
  • Enable Trunk and Terraform format checks on PR.

why

  • Addresses the raised issue.

references

@gberenice gberenice requested a review from a team as a code owner November 20, 2023 15:27
@gberenice gberenice changed the title Fix/update example fix: update examples/complete Nov 20, 2023
Gowiem
Gowiem previously approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change requested, but lets :shipit:

@gberenice @Gowiem
chore: constrain only minimum allowed version of Terraform
46efd08 
Co-authored-by: Matt Gowie  <matt@masterpoint.io>
@gberenice gberenice merged commit 741ea8e into main Nov 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

examples/complete is outdated
2 participants
@gberenice @Gowiem