Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make session ID query-string parameter name also configurable #5

Closed
wants to merge 1 commit into from
Closed

Conversation

pyke369
Copy link
Contributor

@pyke369 pyke369 commented Nov 6, 2010

Only the header name was configurable, the query-string parameter name was always X-Progress-ID.

@masterzen
Copy link
Owner

@sebest, le commit en question est pour le header, le commit de Pierre-Yves addresse le nom du param dans la query-string.

@Pierre-yves:
I'd prefer the following:
*(p + upcf->header.len) == '='
to be:
p[upcf->header.len] == '='

Can you re-do it?

I'd also prefer a commit without the changelog chunk, I'd add it in a subsequent versionning only commit with proper credits.

I'll merge the feature tomorrow :)

Thanks,

@pyke369
Copy link
Contributor Author

pyke369 commented Nov 6, 2010

C'est fait, merci !

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants