Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow url to be an array #54

Closed
wants to merge 2 commits into from

Conversation

zhangtemplar
Copy link

In certain library, it may contain multiple files, e.g., https://unpkg.com/rc-drawer-menu@0.5.7/dist/, one for source code, the other for style file or locale file.

In certain library, it may contain multiple files, e.g., [https://unpkg.com/rc-drawer-menu@0.5.7/dist/](https://unpkg.com/rc-drawer-menu@0.5.7/dist/), one for source code, the other for style file or locale file.
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #54 into master will decrease coverage by 1.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   98.83%   97.72%   -1.11%     
==========================================
  Files           2        2              
  Lines          86       88       +2     
==========================================
+ Hits           85       86       +1     
- Misses          1        2       +1
Impacted Files Coverage Δ
src/index.js 97.64% <66.66%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3e6ae1...fb16359. Read the comment docs.

@aulisius
Copy link
Collaborator

Hi @zhangtemplar , thanks for the PR! All looks good. Can you also add some tests to test against this usecase?

Thanks,
Faizaan.

@zhangtemplar
Copy link
Author

@aulisius sure, give me some time. I found some problem when running the new test.

@mastilver
Copy link
Owner

Hi @zhangtemplar , thank you for the PR. But I don't think it will work

Please tell me if I'm wrong but with your example rc-drawer-menu and without the this webpack plugin, you will need to import each of them one by one; this plugin doesn't change anything and is not suppose to change previous behaviours: if it was working before, it should still work

What we need to do is work on #12 and for module-to-cdn to handle multiple types of assets (css, js, ...)

@zhangtemplar
Copy link
Author

Got you!

@mastilver
Copy link
Owner

closing that, based on above conversation

@mastilver mastilver closed this Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants