Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Suggestion: Deprecate factory constructors in RetryConfig #101

Closed
myConsciousness opened this issue Dec 30, 2022 · 1 comment · Fixed by #102
Closed

Improve Suggestion: Deprecate factory constructors in RetryConfig #101

myConsciousness opened this issue Dec 30, 2022 · 1 comment · Fixed by #102
Assignees
@myConsciousness
Labels
enhancement New feature or request untriaged

Comments

@myConsciousness
Copy link
Member

1. What could be improved

2. Why should this be improved

3. Any risks?

4. More information
@myConsciousness myConsciousness added enhancement New feature or request untriaged labels Dec 30, 2022
@myConsciousness myConsciousness self-assigned this Dec 30, 2022
@github-actions
Copy link

Thanks for your contribution! :)

myConsciousness added a commit that referenced this issue Dec 30, 2022
@myConsciousness
feat: fixed for the issue (#101)
8a8b6fd 
Co-authored-by: myConsciousness <contact@shinyakato.dev>”
myConsciousness added a commit that referenced this issue Dec 30, 2022
@myConsciousness
docs: fixed for the issue (#101)
5518213 
Co-authored-by: myConsciousness <contact@shinyakato.dev>”
@myConsciousness myConsciousness linked a pull request Dec 30, 2022 that will close this issue
fix: fixed for the issue (#101) #102
Merged
7 tasks
bors bot added a commit that referenced this issue Dec 30, 2022
@bors @myConsciousness
Merge #102
31e514e 
102: fix: fixed for the issue (#101) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [x] Yes, this is a breaking change.
- [ ] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/mastodon-dart/mastodon-api/issues
[contributor guide]: https://github.com/mastodon-dart/mastodon-api/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/mastodon-dart/mastodon-api/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <contact@shinyakato.dev>
@bors bors bot closed this as completed in #102 Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@myConsciousness myConsciousness

Labels
enhancement New feature or request untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixed for the issue (#101) mastodon-dart/mastodon-api
1 participant
@myConsciousness