Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#8) #107

Merged
merged 3 commits into from
Jan 1, 2023
Merged

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

Co-authored-by: myConsciousness <contact@shinyakato.dev>”
Co-authored-by: myConsciousness <contact@shinyakato.dev>”
Co-authored-by: myConsciousness <contact@shinyakato.dev>”
@myConsciousness myConsciousness self-assigned this Jan 1, 2023
@myConsciousness myConsciousness linked an issue Jan 1, 2023 that may be closed by this pull request
1 task
@github-actions github-actions bot added service/accounts test v1 Indicates that it is a v1 endpoint. labels Jan 1, 2023
@myConsciousness
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #107 (fccc824) into main (b714e29) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   70.13%   70.26%   +0.12%     
==========================================
  Files          97       97              
  Lines         951      955       +4     
==========================================
+ Hits          667      671       +4     
  Misses        284      284              
Impacted Files Coverage Δ
...b/src/service/v1/accounts/accounts_v1_service.dart 97.89% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bors
Copy link
Contributor

bors bot commented Jan 1, 2023

Build succeeded!

And happy new year! 🎉

@bors bors bot merged commit 748b5e2 into main Jan 1, 2023
@bors bors bot deleted the 8-feature-request-bookmarks-api-methods branch January 1, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/accounts test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: bookmarks API methods
2 participants