Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#118) #119

Merged

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Feb 4, 2023
@myConsciousness myConsciousness linked an issue Feb 4, 2023 that may be closed by this pull request
@github-actions github-actions bot added documentation Improvements or additions to documentation service/accounts service/statuses test v1 Indicates that it is a v1 endpoint. labels Feb 4, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2023

Codecov Report

Merging #119 (a9d2067) into main (5b126ce) will increase coverage by 1.30%.
The diff coverage is 83.33%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   71.12%   72.42%   +1.30%     
==========================================
  Files          98       97       -1     
  Lines        1032     1030       -2     
==========================================
+ Hits          734      746      +12     
+ Misses        298      284      -14     
Impacted Files Coverage Δ
lib/src/service/entities/preview_card.dart 100.00% <ø> (ø)
lib/src/service/entities/status.dart 100.00% <ø> (ø)
lib/src/service/entities/status_context.dart 100.00% <ø> (ø)
lib/src/service/entities/tag.dart 100.00% <ø> (ø)
...b/src/service/v1/accounts/accounts_v1_service.dart 96.87% <50.00%> (-1.02%) ⬇️
...b/src/service/v1/statuses/statuses_v1_service.dart 83.63% <83.33%> (-2.08%) ⬇️
lib/src/service/entities/status_edit.dart 100.00% <100.00%> (ø)
lib/src/service/entities/status_source.dart 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness
Copy link
Member Author

bors merge

@bors bors bot merged commit 2f07585 into main Feb 4, 2023
@bors bors bot deleted the 118-feature-request-add-endpoints-in-statuses-api-methods branch February 4, 2023 14:20
@bors
Copy link
Contributor

bors bot commented Feb 4, 2023

This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried.

Additional information:

Response status code: 422
{"message":"Changes must be made through a pull request.","documentation_url":"https://docs.github.com/articles/about-protected-branches"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation service/accounts service/statuses test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Add endpoints in statuses API methods
2 participants