-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kraigo notifications #122
Kraigo notifications #122
Conversation
bors merge |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 72.14% 72.72% +0.58%
==========================================
Files 97 99 +2
Lines 1034 1056 +22
==========================================
+ Hits 746 768 +22
Misses 288 288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Build succeeded:
|
Hi @Kraigo , Thanks for your contributions! These commits will be released as v0.4.0. :) |
); | ||
}); | ||
|
||
test('when rate limit exceeded', () async { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @myConsciousness why do you need every time test rate limit and authorization response for each request?
I see that is stubbed data which comes from BaseService and all method use that solution.
An endpoint methods should test for available parameters and expected response object.
Did I miss something? What cases can such a case cover?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kraigo ,
These are tests to ensure that each endpoint can reliably handle exception cases :) An exception case that endpoint A can handle perfectly and endpoint B returns a different exception or error would create chaos.
The processing in this package is commonized like a framework, but it’s up to the implementer to be able to use and implement it correctly. So, even if the code is redundant, these common specifications must be tested to ensure their correctness :)
1. Description
1.1. Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.1.2. Breaking Change
1.3. Related Issues