Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kraigo notifications #122

Merged
merged 10 commits into from
Feb 4, 2023
Merged

Kraigo notifications #122

merged 10 commits into from
Feb 4, 2023

Conversation

myConsciousness
Copy link
Member

@myConsciousness myConsciousness commented Feb 4, 2023

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@github-actions github-actions bot added service/notifications test v1 Indicates that it is a v1 endpoint. labels Feb 4, 2023
@myConsciousness myConsciousness linked an issue Feb 4, 2023 that may be closed by this pull request
4 tasks
@myConsciousness
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #122 (347410d) into main (c027916) will increase coverage by 0.58%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   72.14%   72.72%   +0.58%     
==========================================
  Files          97       99       +2     
  Lines        1034     1056      +22     
==========================================
+ Hits          746      768      +22     
  Misses        288      288              
Impacted Files Coverage Δ
lib/src/service/entities/notification.dart 100.00% <100.00%> (ø)
...ice/v1/notifications/notifications_v1_service.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bors
Copy link
Contributor

bors bot commented Feb 4, 2023

Build succeeded:

@bors bors bot merged commit c253875 into main Feb 4, 2023
@bors bors bot deleted the Kraigo-notifications branch February 4, 2023 15:15
@myConsciousness
Copy link
Member Author

Hi @Kraigo ,

Thanks for your contributions! These commits will be released as v0.4.0. :)

);
});

test('when rate limit exceeded', () async {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @myConsciousness why do you need every time test rate limit and authorization response for each request?
I see that is stubbed data which comes from BaseService and all method use that solution.
An endpoint methods should test for available parameters and expected response object.
Did I miss something? What cases can such a case cover?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kraigo ,

These are tests to ensure that each endpoint can reliably handle exception cases :) An exception case that endpoint A can handle perfectly and endpoint B returns a different exception or error would create chaos.

The processing in this package is commonized like a framework, but it’s up to the implementer to be able to use and implement it correctly. So, even if the code is redundant, these common specifications must be tested to ensure their correctness :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/notifications test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: notifications API methods
3 participants