Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#12) #124

Merged
merged 4 commits into from
Feb 5, 2023

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness self-assigned this Feb 5, 2023
@myConsciousness myConsciousness linked an issue Feb 5, 2023 that may be closed by this pull request
3 tasks
@github-actions github-actions bot added client service/accounts test v1 Indicates that it is a v1 endpoint. labels Feb 5, 2023
@myConsciousness
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #124 (dc25e4c) into main (44215aa) will increase coverage by 0.21%.
The diff coverage is 84.61%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   72.72%   72.94%   +0.21%     
==========================================
  Files          99       99              
  Lines        1056     1068      +12     
==========================================
+ Hits          768      779      +11     
- Misses        288      289       +1     
Impacted Files Coverage Δ
lib/src/core/client/client_context.dart 0.00% <0.00%> (ø)
lib/src/core/service_helper.dart 74.71% <ø> (ø)
lib/src/service/base_service.dart 90.58% <ø> (ø)
...b/src/service/v1/accounts/accounts_v1_service.dart 97.04% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bors
Copy link
Contributor

bors bot commented Feb 5, 2023

Build succeeded:

@bors bors bot merged commit 3b868c4 into main Feb 5, 2023
@bors bors bot deleted the 12-feature-request-domain_blocks-api-methods branch February 5, 2023 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client service/accounts test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: domain_blocks API methods
2 participants