Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed for the issue (#125) #129

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

Merging #129 (a577412) into main (3b868c4) will decrease coverage by 0.35%.
The diff coverage is 75.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #129      +/-   ##
==========================================
- Coverage   72.94%   72.59%   -0.35%     
==========================================
  Files          99      100       +1     
  Lines        1068     1069       +1     
==========================================
- Hits          779      776       -3     
- Misses        289      293       +4     
Impacted Files Coverage Δ
lib/src/service/response/mastodon_response.dart 6.66% <0.00%> (-1.67%) ⬇️
...b/src/service/v1/statuses/statuses_v1_service.dart 83.63% <ø> (ø)
lib/src/service/entities/empty.dart 50.00% <50.00%> (ø)
lib/src/service/base_service.dart 90.12% <100.00%> (-0.47%) ⬇️
...b/src/service/v1/accounts/accounts_v1_service.dart 97.04% <100.00%> (ø)
lib/src/service/v1/apps/apps_v1_service.dart 100.00% <100.00%> (ø)
...b/src/service/v1/instance/instance_v1_service.dart 100.00% <100.00%> (ø)
...ice/v1/notifications/notifications_v1_service.dart 100.00% <100.00%> (ø)
...src/service/v1/timelines/timelines_v1_service.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@myConsciousness
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 6, 2023

Build succeeded:

@bors bors bot merged commit 867a23b into main Feb 6, 2023
@bors bors bot deleted the 125-improve-suggestion-deprecate-evaluateresponse branch February 6, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Suggestion: Deprecate evaluateResponse
2 participants