Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#19) #76

Merged
merged 2 commits into from Dec 22, 2022

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness linked an issue Dec 22, 2022 that may be closed by this pull request
1 task
@myConsciousness myConsciousness self-assigned this Dec 22, 2022
@github-actions github-actions bot added service/accounts test v1 Indicates that it is a v1 endpoint. labels Dec 22, 2022
@myConsciousness
Copy link
Member Author

bors merge

bors bot added a commit that referenced this pull request Dec 22, 2022
76: feat: fixed for the issue (#19) r=myConsciousness a=myConsciousness

# 1. Description

<!-- Provide a description of what this PR is doing.
If you're modifying existing behavior, describe the existing behavior, how this PR is changing it,
and what motivated the change. If this is a breaking change, specify explicitly which APIs have been
changed. -->

## 1.1. Checklist

<!-- Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (`[x]`). This will ensure a smooth and quick review process. -->

- [x] The title of my PR starts with a [Conventional Commit] prefix (`fix:`, `feat:`, `docs:` etc).
- [x] I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
- [x] I have updated/added tests for ALL new/updated/fixed functionality.
- [x] I have updated/added relevant documentation in `docs` and added dartdoc comments with `///`.
- [x] I have updated/added relevant examples in `examples`.

## 1.2. Breaking Change

<!-- Does your PR require users to manually update their apps to accommodate your change?

If the PR is a breaking change this should be indicated with suffix "!"  (for example, `feat!:`, `fix!:`). See [Conventional Commit] for details.
-->

- [ ] Yes, this is a breaking change.
- [x] No, this is _not_ a breaking change.

## 1.3. Related Issues

<!-- Provide a list of issues related to this PR from the [issue database].
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx* !-->

<!-- Links -->

[issue database]: https://github.com/mastodon-dart/mastodon-api/issues
[contributor guide]: https://github.com/mastodon-dart/mastodon-api/blob/main/CONTRIBUTING.md
[style guide]: https://github.com/mastodon-dart/mastodon-api/blob/main/STYLEGUIDE.md
[conventional commit]: https://conventionalcommits.org


Co-authored-by: myConsciousness <contact@shinyakato.dev>
@bors
Copy link
Contributor

bors bot commented Dec 22, 2022

Build failed:

@myConsciousness
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

Codecov Report

Merging #76 (3ca9189) into main (7006139) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   69.16%   69.35%   +0.18%     
==========================================
  Files          84       85       +1     
  Lines         827      832       +5     
==========================================
+ Hits          572      577       +5     
  Misses        255      255              
Impacted Files Coverage Δ
lib/src/service/entities/account_preferences.dart 100.00% <100.00%> (ø)
...b/src/service/v1/accounts/accounts_v1_service.dart 97.70% <100.00%> (+0.05%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bors
Copy link
Contributor

bors bot commented Dec 22, 2022

Build succeeded:

@bors bors bot merged commit dbbf207 into main Dec 22, 2022
@bors bors bot deleted the 19-feature-request-preferences-api-methods branch December 22, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/accounts test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: preferences API methods
2 participants