Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed for the issue (#18) #81

Merged
merged 2 commits into from
Dec 26, 2022

Conversation

myConsciousness
Copy link
Member

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

@myConsciousness myConsciousness linked an issue Dec 26, 2022 that may be closed by this pull request
4 tasks
@myConsciousness myConsciousness self-assigned this Dec 26, 2022
@github-actions github-actions bot added service/accounts test v1 Indicates that it is a v1 endpoint. labels Dec 26, 2022
@myConsciousness
Copy link
Member Author

bors merge

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2022

Codecov Report

Merging #81 (1f2eaa5) into main (c874e88) will increase coverage by 0.50%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #81      +/-   ##
==========================================
+ Coverage   69.35%   69.85%   +0.50%     
==========================================
  Files          85       85              
  Lines         832      846      +14     
==========================================
+ Hits          577      591      +14     
  Misses        255      255              
Impacted Files Coverage Δ
lib/src/service/entities/featured_tag.dart 100.00% <ø> (ø)
...b/src/service/v1/accounts/accounts_v1_service.dart 97.93% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bors
Copy link
Contributor

bors bot commented Dec 26, 2022

Build succeeded:

@bors bors bot merged commit e585f30 into main Dec 26, 2022
@bors bors bot deleted the 18-feature-request-featured_tags-api-methods branch December 26, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/accounts test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: featured_tags API methods
2 participants