Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed for the issue (#30) #96

Merged
merged 4 commits into from
Dec 31, 2022
Merged

Conversation

myConsciousness
Copy link
Member

Co-authored-by: myConsciousness contact@shinyakato.dev

1. Description

1.1. Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

1.2. Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

1.3. Related Issues

Co-authored-by: myConsciousness <contact@shinyakato.dev>
@myConsciousness myConsciousness linked an issue Dec 30, 2022 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added service/timelines v1 Indicates that it is a v1 endpoint. labels Dec 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2022

Codecov Report

Merging #96 (71696a9) into main (ae4ec2b) will increase coverage by 0.79%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #96      +/-   ##
==========================================
+ Coverage   68.96%   69.75%   +0.79%     
==========================================
  Files          94       97       +3     
  Lines         915      939      +24     
==========================================
+ Hits          631      655      +24     
  Misses        284      284              
Impacted Files Coverage Δ
...ib/src/service/entities/notification_snapshot.dart 100.00% <100.00%> (ø)
lib/src/service/entities/position_marker.dart 100.00% <100.00%> (ø)
lib/src/service/entities/status_snapshot.dart 100.00% <100.00%> (ø)
...src/service/v1/timelines/timelines_v1_service.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the test label Dec 31, 2022
@myConsciousness myConsciousness self-assigned this Dec 31, 2022
Co-authored-by: myConsciousness <contact@shinyakato.dev>”
@myConsciousness
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Dec 31, 2022

Build succeeded!

And happy new year! 🎉

@bors bors bot merged commit 1a89a97 into main Dec 31, 2022
@bors bors bot deleted the 30-feature-request-markers-api-methods branch December 31, 2022 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/timelines test v1 Indicates that it is a v1 endpoint.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: markers API methods
2 participants