Make list of default servers configurable (IOS-171) #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zeitschlag
commented
Jul 2, 2023
•
zeitschlag
commented
- Download a list of suggested servers from api.joinmastodon.org
- Randomly pick on (based on a weighted list)
- Make the "Join $defaultServer"-button join this instance
Server list from backend has a weight which plays a role in which server gets selected. mastodon.social is the fallback in case something goes wrong
kimar
approved these changes
Jul 2, 2023
|
|
||
| func downloadDefaultServer(completion: (() -> Void)? = nil) { | ||
| context.apiService.defaultServers() | ||
| .timeout(.milliseconds(500) , scheduler: DispatchQueue.main) |
There was a problem hiding this comment.
It's a requirement/design-decision: If getting the list from the server takes longer than 500ms, we fallback to mastodon.social
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.