Remove unused ActivityPub @context values depending on response
#10378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
added
performance
Gargron
force-pushed
the
feature-omit-unused-contexts
branch
from
1084867
to
6eb7c82
Compare
nightpool
approved these changes
Mar 26, 2019
Gargron
force-pushed
the
feature-omit-unused-contexts
branch
2 times, most recently
from
605058c
to
d29d0c7
Compare
Gargron
force-pushed
the
feature-omit-unused-contexts
branch
from
d29d0c7
to
f505bc9
Compare
Gargron
force-pushed
the
feature-omit-unused-contexts
branch
from
f505bc9
to
3dfb366
Compare
hiyuki2578
pushed a commit
to ProjectMyosotis/mastodon
that referenced
this pull request
Oct 2, 2019
messenjahofchrist
pushed a commit
to Origin-Creative/mastodon
that referenced
this pull request
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8078
Each serializer states which contexts it uses, and which context extensions. The only useful named context right now is
security. As for context extensions, they are categorized by features/useful property groups.The adapter then assembles a
@contextdynamically from this information.With less stuff in the
@context, it saves a little bit of bandwidth, a little bit of storage in Sidekiq queues when the JSON is used as job arguments, and the payloads become more readable (glance value).