Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to emoji handling to allow remote emoji #10708

Open
BenLubar opened this issue May 5, 2019 · 1 comment
Open

Changes to emoji handling to allow remote emoji #10708

BenLubar opened this issue May 5, 2019 · 1 comment
Labels
status/wontfix This will not be worked on suggestion Feature suggestion

Comments

@BenLubar
Copy link
Contributor

BenLubar commented May 5, 2019

Pitch

Currently, emoji are recorded by shortcode and domain name. This means that a remote emoji will:

  1. overwrite a local emoji with the same name
  2. be added to a domain that doesn't own it

The domain name should, instead, be the domain of the emoji's id field, verifying that it matches the actual document before storing it in the database similar to how boosted posts aren't implicitly trusted.

Additionally, emoji are not able to be discovered via a search for the ActivityPub URL the way that posts and users can be discovered.

A third issue is that remote emoji and local emoji cannot be referenced in the same post if they have the same name, but this isn't really that big of a problem.

Test case: https://ben.lubar.me/dump/emoji-test-68702b2a-cbdc-4d39-858e-f1b22fcc48a5/post.json (search for @testuser@ben.lubar.me first if this returns no results in Mastodon)

Motivation

This wouldn't immediately make any user-visible changes, but it would make room for future enhancements:

Using remote emoji would be most immediately useful in replies to posts from other domains with content warnings that contain emoji.

It would also allow centralized storage of an emoji library that is shared between multiple domains but none of those domains own the emoji library. In this example, I could use the entirety of Guild Wars 2's item list as an emoji source rather than having to upload thousands of PNGs to my instance before they were available.

@Gargron Gargron added the suggestion Feature suggestion label Aug 5, 2019
@stale
Copy link

stale bot commented Oct 26, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/wontfix This will not be worked on label Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/wontfix This will not be worked on suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests

2 participants