Muting someone may remove existing notifications from them

[ClearlyClaire]

Expected behaviour

When muting someone without disabling notifications from them, existing notifications should not disappear.

Actual behaviour

Existing notifications from muted people disappear from the WebUI if the corresponding toots were also in the Home timeline.

This is because FeedManager#clear_from_timelines (called by MuteWorker) sends a delete to the streaming server, which can't be distinguished from a proper status deletion by the client.

Possible solutions may be:

• do not send a delete in such cases, as the client already does filtering when muting (but other connected clients wouldn't apply the mute retroactively)
• have a new version of the delete event (api/v2/streaming?) having a field allowing to differentiate between a toot that is removed from the timeline and a toot that is completely deleted

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[trwnh]

still an issue?

[ClearlyClaire]

yes