Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decimals cause profile counters to overflow container and wrap to new line #12699

Closed
trwnh opened this issue Dec 28, 2019 · 1 comment · Fixed by #12706
Closed

Decimals cause profile counters to overflow container and wrap to new line #12699

trwnh opened this issue Dec 28, 2019 · 1 comment · Fixed by #12706

Comments

@trwnh
Copy link
Member

trwnh commented Dec 28, 2019

image

mastodon.social

I'd consider removing the decimal because it is usually not that significant. Or alternatively, only show 3 significant figures at most, i.e., when the count is 3 digits, do not show the decimal.

3 sig figs No decimals
image image
@noellabo
Copy link
Contributor

Pull-requested a fix to change shortNumberFormat to return shorter notation.

1 = 1
12 = 12
123 = 123
1234 = 1.2K
12345 = 12K
123456 = 123K
1234567 = 1.2M
12345678 = 12M
123456789 = 123M
1234567890 = 1234M

Also, when translating Toots, Follows, Followers, it may not be possible to prevent overflow because it may be a longer string.
For this reason, the interval for multiple lines has been adjusted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants