Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Federating with Lemmy - Don't boost comments #18069

Closed
UserThre3 opened this issue Apr 22, 2022 · 14 comments
Closed

Federating with Lemmy - Don't boost comments #18069

UserThre3 opened this issue Apr 22, 2022 · 14 comments
Labels
bug Something isn't working

Comments

@UserThre3
Copy link

Steps to reproduce the problem

  1. Subscribe to Lemmy community
  2. Wait for new comments
  3. Check Home timeline, it's flooded with comments to subscribed communities.

Discussion on Lemmy github re. this issue LemmyNet/lemmy#2224

Expected behaviour

Nothing. Comments should be attached to the post.

Actual behaviour

Comments gets boosted in the same way as community posts

Specifications

Mastodon 3.5.1
Lemmy 0.16.3

@UserThre3 UserThre3 added the bug Something isn't working label Apr 22, 2022
@nightpool
Copy link
Member

I'm sorry, but this bug report doesn't make any sense. If you follow the community, you'll get all of the posts the community makes in your home timeline. If the community is sending us Announce activity (like Lemmy says they are), then you'll get those boosts in your home timeline. That's what Announce means. If Lemmy wants them to not appear in their follower's timelines, then they can do something besides Announceing them. (For example, they could use Inbox Forwarding)

@aschrijver
Copy link

FYI cc @Nutomic in case you missed Nightpool's comment :)

@Nutomic
Copy link

Nutomic commented May 3, 2022

@aschrijver Thanks for the heads up!

@nightpool I dont see how the inbox filtering is related, it seems to be for delivering activities in case the original sender couldnt deliver them. In this case the problem is that Mastodon receives and displays activities from Lemmy (Announce/Create/Note) which the user doesnt want to see. This is due to a recent change in Mastodon, previously it didnt accept activities with this type at all.

@RokeJulianLockhart
Copy link

So... whose fault is it?

@Snowpop
Copy link

Snowpop commented Jun 18, 2023

Also experiencing this issue. Hope we can find a solution!

@Sir-Photch
Copy link

+1

@steelswords
Copy link

Same problem here. It's very annoying. Started a week or so ago for me on fosstodon.org

@nightpool
Copy link
Member

nightpool commented Jul 8, 2023

I dont see how the inbox filtering is related, it seems to be for delivering activities in case the original sender couldnt deliver them

Not sure how what something "seems to be for" is relevant. This mechanism, Inbox Forwarding, is the way every single other ActivityPub server implements reply forwarding to distribute replies to their activities. It's specifically said in the text of the spec to be designed to solve the ghost reply problem, which is the exact same problem Lemmy is trying to solve (i.e. "for groups to send activities to their followers"). If Lemmy wants to use boosts instead then that's their prerogative, but it's pretty clear that most users are annoyed by that decision.

@Archenoth
Copy link

Sorry if the last response actually did send a notification, but just in case, uh, paging @Nutomic!

(Also, pardon the bump! I figured replying to this instead of making a new issue would probably be the least annoying way to ask if there was a way for lemmy and mastodon to coexist in a way that takes over your timeline less, and figuring out if this was even the right place to ask about that)

@Nutomic
Copy link

Nutomic commented Sep 12, 2023

@Archenoth What do you ping me for? Federation is working fine between Lemmy instances, and is completely in line with the Activitypub standard. Its not my concern if Mastodon doesnt support this properly, Im not getting paid to solve their problems.

@Archenoth
Copy link

@Nutomic the tl;dr version is that @nightpool's comment seemed to suggest the ball is in Lemmy's court again, so I was wondering if you'd seen it, since this is where the most recent conversation about this problem has been

(Sorry if you had ^^')

The less-tl;dr version is that , even though both this issue and the original one in the Lemmy repo are closed, the original issue @UserThre3 reported in both places still remains! If you follow a lemmy community of mostly any size from mastodon, it will overwhelm your feed by boosting all activity inside every post into your feed--enough traffic to completely monopolize your feed if you don't follow thousands of people

  • It seems like the original reason Lemmy did this was so that it would federate properly (I can confirm it does!)
  • Lemmy and Mastodon also both seem to be implementing ActivityPub just fine too, so this isn't about that either

However, the suggestion to use Inbox Forwarding as a way to federate replies without needing to Announce every one of them was because it seems like the original Lemmy feature was to make it able to interop with mastodon, and that is currently preeeeetty broken, and this would be a standards-compliant way to make that less so

@Archenoth
Copy link

Oh! And the ping was because it seemed like this issue might fall through the cracks since both sides were mutually okay with waiting for a fix from a project that didn't feel like there was anything to do

So I was hoping drawing your attention here would either lead to either a "Mastodon needs to do X for this to work" or a "Oh! Lemmy would need to X for this to work" so that we could figure out a way for Mastodon and Lemmy to interact in a usable way (Because this issue seems to be a pretty common reason for people not doing that)

Sorry for the extra inbox traffic ^^'

@Nutomic
Copy link

Nutomic commented Sep 13, 2023

I think I explained this already before, but gonna clarify it once more: The Activitypub standard allows many different ways to implement the same functionality, so what Mastodon and Lemmy are doing is both in line with the standard. Specifically Lemmy implements FEP-1b12 which is the de facto Fediverse standard for group federation. Im not sure if inbox forwarding would work for Lemmy. There is a high chance it wont because Lemmy has to forward much more complex data than only simple Notes. In any case its way too late to change this now, as it would require a major rewrite of Lemmy code, thorough testing and some way to make a backwards compatible migration. Lots of work with zero benefit for Lemmy users. Believe me we have tons of work which is much more important and less effort. And no, Mastodon interop was never "the original Lemmy feature". The main feature was always federation between Lemmy instances.

So the solution here is for Mastodon to implement group support according to FEP-1b12, and render group posts differently from microblogging posts. There is #19059 which goes in this direction, although for some reason it implements group federation in a way thats intentionally incompatible with Lemmy, and hasnt been updated in a year.

To be honest I doubt that posting this will really change anything. Mastodon maintainers probably wont read this, and they dont seem to have any interest to improve Lemmy compatibility. But maybe I will be proven wrong.

@Archenoth
Copy link

Oh, damn. Yeaaaah I think it makes total sense why that would be a no-go ^^'

Thank you for explaining! (And hopefully the masto-side eventually ends up being able to handle this more gracefully!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

9 participants