Fix single Redis connection being used across all threads #18135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gargron
force-pushed
the
fix-sidekiq-redis-connection-pool
branch
3 times, most recently
from
5dcc753
to
9c89329
Compare
Gargron
changed the title
Gargron
force-pushed
the
fix-sidekiq-redis-connection-pool
branch
from
9c89329
to
041955a
Compare
ykzts
approved these changes
Apr 27, 2022
Comment on lines
-10
to
-14
| if namespace | ||
| Redis.current = Redis::Namespace.new(namespace, redis: redis_connection) | ||
| else | ||
| Redis.current = redis_connection | ||
| end |
There was a problem hiding this comment.
config/initializers/stoplight.rb is still using Redis.current, so this is likely to cause issues, at least when REDIS_NAMESPACE
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
May 4, 2022
…8135) * Fix single Redis connection being used across all Sidekiq threads * Fix tests
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
…8135) * Fix single Redis connection being used across all Sidekiq threads * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ideal solution is to check-out Redis from the pool whenever Redis is used and then check it back in, but since that would require rewriting a lot more code, this should help in the meantime...
This enables connection pooling for Rails cache and ensures that each thread gets its own Redis connection.