Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change RSS feeds #18356

Merged
merged 4 commits into from
May 9, 2022
Merged

Change RSS feeds #18356

merged 4 commits into from
May 9, 2022

Conversation

Gargron
Copy link
Member

@Gargron Gargron commented May 8, 2022

  • Use date and time for titles instead of ellipsized text
  • Use full content in body, even when there is a content warning
  • Use media extensions

Fix #17392, fix #14538, fix #10782

@Gargron Gargron force-pushed the feature-better-rss-feeds branch 5 times, most recently from 1dca178 to 414cb38 Compare May 8, 2022 07:01
- Use date and time for titles instead of ellipsized text
- Use full content in body, even when there is a content warning
- Use media extensions
@Gargron Gargron merged commit 2b8dc58 into main May 9, 2022
@Gargron Gargron deleted the feature-better-rss-feeds branch May 9, 2022 05:47
end

def animate?
@options[:animate]
@options[:animate] || @options.key?(:style)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use inline styles, we won't be using JS to animate on-hover

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, though that makes the method's name pretty misleading and the whole thing a little harder to understand.

kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request May 27, 2022
* Change RSS feeds

- Use date and time for titles instead of ellipsized text
- Use full content in body, even when there is a content warning
- Use media extensions

* Change feed icons and add width and height attributes to custom emojis

* Fix custom emoji animate on hover breaking

* Fix tests
ClearlyClaire pushed a commit to ClearlyClaire/mastodon that referenced this pull request Jul 6, 2023
* Change RSS feeds

- Use date and time for titles instead of ellipsized text
- Use full content in body, even when there is a content warning
- Use media extensions

* Change feed icons and add width and height attributes to custom emojis

* Fix custom emoji animate on hover breaking

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants