Refactor how Redis locks are created #18400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
requested changes
May 12, 2022
ykzts
approved these changes
May 12, 2022
ClearlyClaire
requested changes
May 12, 2022
| RedisLock.acquire(lock_options) do |lock| | ||
| if lock.acquired? | ||
| already_voted = @poll.votes.where(account: @account).exists? | ||
| with_lock("vote:#{@poll.id}:#{@account.id}") do |
There was a problem hiding this comment.
This changes the autorelease duration, but maybe it's not a bad thing.
| else | ||
| raise Mastodon::RaceConditionError | ||
| end | ||
| with_lock("distribute:#{status_id}") do |
There was a problem hiding this comment.
This changes the autorelease duration (from 5 minutes to 15 minutes), but not sure this matters.
| @@ -12,22 +12,22 @@ def perform | |||
| private | |||
|
|
|||
| def delete_person | |||
| lock_or_return("delete_in_progress:#{@account.id}") do | |||
| with_lock("delete_in_progress:#{@account.id}", raise_on_failure: false) do | |||
There was a problem hiding this comment.
This changes the autorelease from 2 hours to 15 minutes. DeleteAccountService can potentially take a really long time to return, so 15 minutes might be too short of a duration in certain cases.
ClearlyClaire
approved these changes
May 12, 2022
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
May 27, 2022
* Refactor how Redis locks are created * Fix autorelease duration on account deletion lock
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
* Refactor how Redis locks are created * Fix autorelease duration on account deletion lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.