Replace to workbox-webpack-plugin from offline-plugin
#18409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykzts
added
dependencies
|
Conflicts resolved. |
Gargron
approved these changes
Aug 25, 2022
|
Conflicts resolved. |
kadoshita
pushed a commit
to kadoshita/mastodon
that referenced
this pull request
Nov 19, 2022
ClearlyClaire
pushed a commit
to ClearlyClaire/mastodon
that referenced
this pull request
Jul 6, 2023
numemac
reviewed
Dec 29, 2023
| registerRoute( | ||
| ({ request }) => ['audio', 'image', 'track', 'video'].includes(request.destination), | ||
| new CacheFirst({ | ||
| cacheName: `m${CACHE_NAME_PREFIX}media`, |
There was a problem hiding this comment.
I wonder why 'm' is prefixed to CACHE_NAME_PREFIX.
My guess it's a mistake from when typing in media?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separated from #18369.
The
offline-pluginwe use for Service Worker has not been maintained for many years (3 years since the last release) and does not support webpack v5. Therefore, it is not possible to migrate to webpack v5 or to Shakapacker, which depends on webpack v5. Replaceoffline-pluginwithworkbox-webpack-pluginwhich supports both webpack v5 and webpack v4 for better compatibility.