Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo Announce activity is not sent when unboosting posts from unfollowed remote accounts #18471

Closed
MitarashiDango opened this issue May 21, 2022 · 1 comment · Fixed by #18482
Labels
bug Something isn't working

Comments

@MitarashiDango
Copy link
Contributor

MitarashiDango commented May 21, 2022

Steps to reproduce the problem

  1. Boost posts on remote accounts that don't follow you.
  2. Remove boost.
    ...

Expected behaviour

Undo Announce activity sent to remote server.

Actual behaviour

Undo Announce activity is not sent.

Specifications

Reproducible version: v3.5.2

Note

The process of sending an Undo Announce was probably introduced with the following commit.
#7959

However, the relevant part has been rewritten with the following commit. (However, looking at his implementation of StatusReachFinder at the time, it seems to be working fine at the time of this commit.)
e7e099d

https://github.com/mastodon/mastodon/blob/e7e099d1a06700d14fa10258f5509fc5c52738c8/app/lib/status_reach_finder.rb

In the latest version, the following conditional branch processing is introduced in StatusReachFinder, and it seems that the URL of Inbox is not returned in the case of posting.

if @status.reblog?

@nightpool
Copy link
Member

Thanks, this appears to be a regression from #16051 (not any of the other issues linked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants