Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Punycode-Domain is displayed raw since update to version 4.0.2 #20906

Closed
Athesis opened this issue Nov 16, 2022 · 4 comments · Fixed by #21440
Closed

Punycode-Domain is displayed raw since update to version 4.0.2 #20906

Athesis opened this issue Nov 16, 2022 · 4 comments · Fixed by #21440
Labels
bug Something isn't working

Comments

@Athesis
Copy link

Athesis commented Nov 16, 2022

Steps to reproduce the problem

Use a Punycode-Domain

Expected behaviour

Show human readable domain (for example ratatöskr.de)

Actual behaviour

Shows Raw Punycode (for example xn--ratatskr-r4a.de)

Detailed description

When using a Punycode Domain (For example, my Server https://www.ratatöskr.de) everywhere the domain is written in raw punycode (xn--ratatskr-r4a.de) instead of the human-readable domain (ratatöskr.de). Version 3.5.3 was handling it for most written domains correctly.

Specifications

Mastodon 4.0.2
Ruby 3.0.4

@Athesis Athesis added the bug Something isn't working label Nov 16, 2022
@ineffyble
Copy link
Member

ineffyble commented Nov 17, 2022

Probably same root cause as #20422. Are you able to test if you have the same issue with usernames and mentions?

@Athesis
Copy link
Author

Athesis commented Nov 17, 2022

No, mentions are working fine.

@ineffyble ineffyble linked a pull request Nov 23, 2022 that will close this issue
@qwell
Copy link

qwell commented Nov 23, 2022

There are quite a few places where punycode show up strangely. URLs in profile fields, for example, show the https://, while no other type of link does.

An example of this can be seen at https://ꩰ.com/@north.

If anybody needs to do testing with this, I'd be happy to provide an account at that domain.

@qwell
Copy link

qwell commented Nov 23, 2022

FWIW, this is what a post from a punycode instance looks like, with a bunch of different links and tags. All links and tags were input correctly, with links including https://. This image is from the viewpoint of a remote user, but it's basically the same for the local user after sending.

Links 1 and 2 were entered as punycode domains - the results are not links. Links 3 and 4 were entered as their decoded (xn--8r9a) form.
User 1 was a local tag with no domain. User 2 was a full tag with punycode domain - the result is not a link. User 3 was a full tag in decoded form. User 4 is a full tag to a remote user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants