Autofix Rails/EagerEvaluationLogMessage #23429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
force-pushed
the
Rail-EagerEvaluationLogMessage
branch
from
5b5980e
to
e76c227
Compare
nschonni
changed the title
Gargron
approved these changes
Feb 7, 2023
btrd
pushed a commit
to btrd/mastodon
that referenced
this pull request
Feb 22, 2023
* Autofix Rails/EagerEvaluationLogMessage * Update spec for debug block syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this message on on of the other PRs, and read the https://guides.rubyonrails.org/debugging_rails_applications.html#impact-of-logs-on-performance.
Seems like a safe/performance related change, os I ran
bundle exec rubocop -a --only Rails/EagerEvaluationLogMessageto just autofix the one issue