Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Rubocop Style/FrozenStringLiteralComment #23793

Merged
merged 1 commit into from Jul 12, 2023
Merged

Enable Rubocop Style/FrozenStringLiteralComment #23793

merged 1 commit into from Jul 12, 2023

Conversation

nschonni
Copy link
Contributor

https://docs.rubocop.org/rubocop/cops_style.html#stylefrozenstringliteralcomment

Adds the remaining pragmas after the separate pass for spec/. Not sure if the test coverage/migration tests would catch everthing for the DB migration or not

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from a072087 to 115a0a7 Compare March 16, 2023 05:24
@github-actions
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from 115a0a7 to 9e8e83b Compare March 17, 2023 20:22
@github-actions
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from 9e8e83b to d5890df Compare March 26, 2023 00:03
@github-actions
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from d5890df to 9fc71b0 Compare March 27, 2023 15:05
@github-actions
Copy link
Contributor

This pull request has resolved merge conflicts and is ready for review.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from 9fc71b0 to cc70ef5 Compare April 3, 2023 20:58
@renchap renchap added ruby Pull requests that update Ruby code lint fix 💅 labels May 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2023

This pull request has resolved merge conflicts and is ready for review.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from cc70ef5 to d2f2437 Compare July 2, 2023 19:58
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This pull request has merge conflicts that must be resolved before it can be merged.

@nschonni nschonni force-pushed the Style-FrozenStringLiteralComment branch from d2f2437 to 1af7bf2 Compare July 8, 2023 18:43
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2023

This pull request has resolved merge conflicts and is ready for review.

@ClearlyClaire ClearlyClaire merged commit 1d55730 into mastodon:main Jul 12, 2023
28 checks passed
@nschonni nschonni deleted the Style-FrozenStringLiteralComment branch July 12, 2023 07:50
jsgoldstein pushed a commit to jsgoldstein/mastodon that referenced this pull request Jul 21, 2023
@nschonni @jsgoldstein
Enable Rubocop Style/FrozenStringLiteralComment (mastodon#23793)
ff48a51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClearlyClaire ClearlyClaire ClearlyClaire approved these changes

Assignees
No one assigned
Labels
lint fix 💅 ruby Pull requests that update Ruby code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nschonni @ClearlyClaire @renchap