Add spec coverage for Admin::Trends::StatusesHelper #23898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
helper-spec-admin-trends-statuses
branch
from
aebc62e
to
dfe124b
Compare
ClearlyClaire
requested changes
Mar 2, 2023
Comment on lines
41
to
52
| context 'with a status that has emoji' do | ||
| let(:status) { Fabricate.build(:status, text: 'hello there :florpy:') } | ||
|
|
||
| it 'renders a correct preview text' do | ||
| result = helper.one_line_preview(status) | ||
|
|
||
| expect(result).to eq 'hello there :florpy:' | ||
| end | ||
| end |
There was a problem hiding this comment.
Since the :florpy: custom emoji is never defined anywhere, that test does not really test anything different than “renders a correct preview text”. I'd suggest either removing it or defining a proper custom emoji.
There was a problem hiding this comment.
Oh good catch ... I feel like I had this in place and may have lost in a rebase. Will update and push changes.
There was a problem hiding this comment.
Pushed a change which restores the creation of the florpy custom emoji.
mjankowski
force-pushed
the
helper-spec-admin-trends-statuses
branch
from
dfe124b
to
5269572
Compare
ClearlyClaire
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.