Pending example models minimal coverage #23912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#23779 is the other stub ones that Rubocop found |
mjankowski
force-pushed
the
pending-example-models
branch
2 times, most recently
from
66e7f62
to
ceab640
Compare
mjankowski
force-pushed
the
pending-example-models
branch
from
ceab640
to
8c0d6c6
Compare
Gargron
approved these changes
Mar 4, 2023
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
rutvijmehta-harness
added a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Matt Jankowski <matt@jankowski.online>
arachnist
pushed a commit
to arachnist/mastodon
that referenced
this pull request
Apr 4, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal here was to get all of the "add some examples or delete" output out of the spec run. For all of those models I just added whatever the first thing I noticed from the model that was straightforward to add. Basically all of them could stand for more coverage to be added, but this first stab accomplishes the goal of getting rid of the "add or delete" output.
There are still a bunch of
pendingorxitinstances left which I haven't addressed here but might separately in future PR.