Restore missing fabricators #23951
Merged
Restore missing fabricators #23951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjankowski
force-pushed
the
missing-fabricators
branch
from
7664a55
to
e093c8e
Compare
Gargron
approved these changes
Mar 4, 2023
rutvijmehta-harness
pushed a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
rutvijmehta-harness
added a commit
to rutvijmehta-harness/mastodon
that referenced
this pull request
Mar 19, 2023
Co-authored-by: Matt Jankowski <matt@jankowski.online>
arachnist
pushed a commit
to arachnist/mastodon
that referenced
this pull request
Apr 4, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of my recent PRs removed a bunch of unused fabricators ... but then on a separate branch I added some specs which did in fact use some of those fabricators! This restores the ones which wound up being used by the added specs.
I think there may be a separate failure present here in the merged-in stuff related to a different rebase. Will check that out separately.