Fix missing translation in pagination gap tags #24262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/views/kaminari/_gap.html.haml
Outdated
| per_page: number of items to fetch per page | ||
| remote: data-remote | ||
| %span.page.gap | ||
| = sanitize t('pagination.truncate') |
There was a problem hiding this comment.
Why the sanitize call?
There was a problem hiding this comment.
pagination.truncate is already translated as … in many locales.
If omit it, the gap will shown as "…".
mastodon/config/locales/ja.yml
Line 1360 in 0d70dee
There was a problem hiding this comment.
Ah, but sanitize allows some of HTML tags...
Would it be better to call sanitize t('pagination.truncate'), tags: [], attributes: [] to disallow them?
ClearlyClaire
approved these changes
Mar 29, 2023
Gargron
requested changes
Mar 29, 2023
Gargron
approved these changes
Mar 29, 2023
arachnist
pushed a commit
to arachnist/mastodon
that referenced
this pull request
Apr 4, 2023
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Co-authored-by: Eugen Rochko <eugen@zeonfederated.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #24261, where i18n of paginator's gap is fallbacks or displayed as translation missing error "Truncate".