Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 pictures in post #24461

Open
mkostera opened this issue Apr 8, 2023 · 14 comments
Open

4 pictures in post #24461

mkostera opened this issue Apr 8, 2023 · 14 comments
Labels
suggestion Feature suggestion

Comments

@mkostera
Copy link

mkostera commented Apr 8, 2023

Pitch

Mastodon should allow more pictures in post at least. Ideally without limitation.

Motivation

Different Fediverse software allow add more pictures to post, but it's not visible in Mastodon. This reduces the usability of Mastodon.

@mkostera mkostera added the suggestion Feature suggestion label Apr 8, 2023
@joaoGabriel55
Copy link
Contributor

I can work on a solution for that @mkostera!

@joaoGabriel55
Copy link
Contributor

joaoGabriel55 commented Apr 10, 2023

@mkostera I think that would be good think in another limit number, cause allow the user send photos without limits can generate some side-effects. The Twitter case, only accept 4 images as Mastodon.

@joaoGabriel55
Copy link
Contributor

joaoGabriel55 commented Apr 10, 2023

What do you think @Gargron?

@cdp1337
Copy link

cdp1337 commented Apr 19, 2023

I'm whipping up a solution for this on my personal fork, I set the arbitrary limit to 24 images just to not overwhelm the server too much, but still allow the user to select more images at a time. I'm also "fixing" some Javascript by moving the presentation logic of image sizes and positions into the CSS where it should have been in the first place.

If Gargron is interested in this feature, I can put together a merge request once it's complete, otherwise it'll just live in my personal repo.

I'm not opposed to increasing the number to something higher than 24, but given how Mastodon is built, it's hard-coded in a bunch of places to expect something. What'cha think? 24 good enough? 48?

Working example of a single post with 14 images

Working (dev) screenshot of a post with 14 images attached

@mkostera
Copy link
Author

. I'm also "fixing" some Javascript by moving the presentation logic of image sizes and positions into the CSS where it should have been in the first place.

If you mean ordering of picture, then PLEASE make merge request ASAP. It's really annoying bug.
#24462

@ismailghedamsi
Copy link

ismailghedamsi commented May 6, 2023

I really need this. Every day I post new images of hip-hop albums that dropped generally there is more than 4 albums that dropped and on Friday it's over 20

@mkostera I think that would be good think in another limit number, cause allow the user send photos without limits can generate some side-effects. The Twitter case, only accepts 4 images as Mastodon.

The more advantage Mastodon have over Twitter the better. Also, Instagram and Facebook also allows 10 pictures.

@tejunk
Copy link

tejunk commented Jun 17, 2023

It would be great to see the solution.

@ileodo
Copy link
Contributor

ileodo commented Feb 1, 2024

I'm whipping up a solution for this on my personal fork, I set the arbitrary limit to 24 images just to not overwhelm the server too much, but still allow the user to select more images at a time. I'm also "fixing" some Javascript by moving the presentation logic of image sizes and positions into the CSS where it should have been in the first place.

If Gargron is interested in this feature, I can put together a merge request once it's complete, otherwise it'll just live in my personal repo.

I'm not opposed to increasing the number to something higher than 24, but given how Mastodon is built, it's hard-coded in a bunch of places to expect something. What'cha think? 24 good enough? 48?

Working example of a single post with 14 images

Working (dev) screenshot of a post with 14 images attached

@cdp1337 great work! do you have a clean commit (or PR) for that changes in your personal fork?

@ileodo
Copy link
Contributor

ileodo commented Feb 3, 2024

#29073 made this PR as a baby step.

@cdp1337
Copy link

cdp1337 commented Feb 4, 2024

@cdp1337 great work! do you have a clean commit (or PR) for that changes in your personal fork?

I try to maintain branches with each individual feature I implement so others can cherry pick what they want to port. My version was on the 4.1 codebase so it's out of date now, but working tonight to port it to latest 4.2 stable, (it'll be available under features/4.2-whatever-issue-number in my personal repo when I'm done).

@ileodo
Copy link
Contributor

ileodo commented Feb 5, 2024

@cdp1337 thanks! I found that a few days back and made a #29073 PR to unify all the magic number 4 first.

@cdp1337
Copy link

cdp1337 commented Feb 5, 2024

Oh nice, I see you're using a configurable parameter in your version! That's a good idea; I was contemplating doing that in my fork, but ultimately opted against unnecessary complications in the code. This has been a feature request for at least 4 years, but Eugene has thus far refused to deviate away from a fixed 4-tile concept.

@ileodo
Copy link
Contributor

ileodo commented Feb 5, 2024

I can feel that. from my point of view, even it has to be 4, this magic number has to be unified. (so people have different idea can easily config their instance differently).

also in the instance api end point, there is a field max_media_attachement, not sure if that means the community want it to be a configurable parameter.

@ileodo
Copy link
Contributor

ileodo commented May 22, 2024

#29073 is passing CI and ready for review&merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
suggestion Feature suggestion
Projects
None yet
Development

No branches or pull requests

6 participants